ci: add Codecov coverage reporting with an enforced minimum threshold#21
Merged
Conversation
Wires dotnet test's existing coverlet.collector reference into an actual coverage report (previously referenced but never collected), uploads it via Codecov's tokenless GitHub OIDC flow, and adds codecov.yml gating project coverage at 85% and patch coverage at 80% - a few points below the current ~95% unit-test baseline so there's headroom without losing a real regression gate. Coverage reflects Monnify.Tests only since IntegrationTests are skipped in CI (no sandbox credentials) and contribute nothing to the report.
The tokenless OIDC upload failed with "Repository not found" - Codecov has never synced this repo, so upload requires activating it on codecov.io first. Rather than depend on that, run Monnify.Tests with coverage collection separately from the full test pass and fail the build below an 85% line floor by parsing the cobertura report coverlet already produces - no external account or token needed. Current baseline is ~95%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires dotnet test's existing coverlet.collector reference into an actual coverage report (previously referenced but never collected), uploads it via Codecov's tokenless GitHub OIDC flow, and adds codecov.yml gating project coverage at 85% and patch coverage at 80% - a few points below the current ~95% unit-test baseline so there's headroom without losing a real regression gate. Coverage reflects Monnify.Tests only since IntegrationTests are skipped in CI (no sandbox credentials) and contribute nothing to the report.
What and why
Checklist
dotnet test)dotnet format --verify-no-changespassesCHANGELOG.mdupdated under[Unreleased]docs/COMPATIBILITY.mdupdated for any endpoint you implemented or changed